Skip to content

OCPVE-645: add CloudCredential capability #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Dec 4, 2023
Merged

OCPVE-645: add CloudCredential capability #1571

openshift-merge-bot merged 2 commits into from
Dec 4, 2023

Conversation

@qJkee
Copy link
Contributor

@qJkee qJkee commented Aug 28, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2023 •
edited by openshift-ci bot
Loading

@qJkee: This pull request references OCPVE-645 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2023
@qJkee qJkee force-pushed the OCPVE-645 branch 4 times, most recently from 2e74833 to 0452d03 Compare August 30, 2023 13:31
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2023
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2023
@qJkee qJkee force-pushed the OCPVE-645 branch 2 times, most recently from d53bf61 to 4e8a5ac Compare November 10, 2023 15:09
@qJkee qJkee mentioned this pull request Nov 23, 2023
Merged
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Nov 23, 2023

CC @jstuever @dlom can either of you think of issues that might occur with disabling this operator. Is it strictly required for any of the other capabilities to operate? I would have initially proposed that this should only be disabled if all other cloud functionality is disabled but I expect we can be a bit more relaxed here since users could supply their own credentials right?

@jstuever
Copy link
Contributor

jstuever commented Nov 27, 2023

CC @jstuever @dlom can either of you think of issues that might occur with disabling this operator. Is it strictly required for any of the other capabilities to operate? I would have initially proposed that this should only be disabled if all other cloud functionality is disabled but I expect we can be a bit more relaxed here since users could supply their own credentials right?

Correct. The various components can operate just fine if the required credential secrets are being manually managed by the user. This is logically the equivalent to CCO being enabled in cluster and in manual mode.... at which point it does practically nothing (STS aside).

@dlom
Copy link

dlom commented Nov 28, 2023

/retest

qJkee added 2 commits November 29, 2023 10:59
@qJkee
add CloudCredential capability
6a928e3
@qJkee
add CloudCredential annotation to manifests
c82af0d 
Add CloudCredential capability annotation to cloud credential
operator related manifests
@jstuever
Copy link
Contributor

jstuever commented Nov 29, 2023

/retest

2 similar comments
@qJkee
Copy link
Contributor Author

qJkee commented Nov 30, 2023

/retest

@jstuever
Copy link
Contributor

jstuever commented Nov 30, 2023

/retest

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Dec 4, 2023

/lgtm

QE have validated this, and after some changes, appear to be happy with it. CCO PR looks good to go apart from the API vendor bump.

@qJkee If for any reason the PRs for this feature do not merge before the 4.15 branch cut, please let me know

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2023

/retest-required

Remaining retests: 0 against base HEAD f220962 and 2 for PR HEAD c82af0d in total

@qJkee
Copy link
Contributor Author

qJkee commented Dec 4, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bfea29e into openshift:master Dec 4, 2023
@openshift-bot
Copy link

openshift-bot commented Dec 4, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202312042232.p0.gbfea29e.assembly.stream for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@qJkee @openshift-ci-robot @JoelSpeed @jstuever @dlom @openshift-bot @openshift-merge-robot